Skip to content

Add visibility read to response collection properties#34128

Merged
lmazuel merged 1 commit intoAzure:mainfrom
JoshLove-msft:eg-readonly
Apr 23, 2025
Merged

Add visibility read to response collection properties#34128
lmazuel merged 1 commit intoAzure:mainfrom
JoshLove-msft:eg-readonly

Conversation

@JoshLove-msft
Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft commented Apr 22, 2025

We should confirm that these models will never be used as inputs in the future.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 22, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Apr 22, 2025

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk azure-sdk mentioned this pull request Apr 22, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 22, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/messaging/eventgrid/aznamespaces

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Apr 22, 2025
This was referenced Apr 22, 2025
Closed
Closed
Closed
Closed
@lmazuel lmazuel merged commit 67e4366 into Azure:main Apr 23, 2025
42 of 51 checks passed
@weshaggard
Copy link
Copy Markdown
Member

weshaggard commented Apr 23, 2025

@JoshLove-msft any reason you didn't update the swagger files with this change? The TypeSpec Validation failure is complaining about that.

@JoshLove-msft
Copy link
Copy Markdown
Member Author

JoshLove-msft commented Apr 23, 2025

@JoshLove-msft any reason you didn't update the swagger files with this change? The TypeSpec Validation failure is complaining about that.

Oops, forgot about that. Looks like it will get updated in #34182.

@JoshLove-msft
Copy link
Copy Markdown
Member Author

JoshLove-msft commented Apr 23, 2025 •
edited
Loading

@JoshLove-msft any reason you didn't update the swagger files with this change? The TypeSpec Validation failure is complaining about that.

Oops, forgot about that. Looks like it will get updated in #34182.

But part of the reason is the amount of CI stages that are failing but titled with "IGNORE". It makes it easy to miss issues when there are so many false positives.

Ideally, we could rely on the CI checks to tell us whether or not the PR can be merged.

koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
@JoshLove-msft @koen-mertens
Add visibility read to response collection properties (Azure#34128)
cd7c654
@samvaity samvaity mentioned this pull request Jun 6, 2025
Closed
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
@JoshLove-msft
Add visibility read to response collection properties (Azure#34128)
1968f91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@l0lawrence l0lawrence Awaiting requested review from l0lawrence

Assignees

No one assigned

Labels

Event Grid TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoshLove-msft @weshaggard @lmazuel @AzureRestAPISpecReview